Skip to content

OCPBUGS-64777: [release-4.20] Add e2e tests for storage network policy #30468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

OCPBUGS-64777: [release-4.20] Add e2e tests for storage network policy #30468

merged 1 commit into from
Nov 26, 2025
+428 −0

Conversation

@duanwei33
Copy link
Contributor

@duanwei33 duanwei33 commented Nov 10, 2025 •
edited
Loading

Cherry-pick of #30359 to release-4.20

Summary

Add e2e tests for storage network policy labels. The automatic cherry-pick failed in the /verify CI job.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2025

@duanwei33: This pull request references Jira Issue OCPBUGS-64777, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-64778 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64778 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of #30359 to release-4.20

Summary

Add e2e tests for storage network policy labels.

Test Plan

  • Verified e2e tests pass locally
  • CI tests will validate on cherry-pick branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Add e2e tests for storage network policy labels
7313ec8 
This adds comprehensive e2e tests to verify that storage-related
operators and controllers have the required network policy labels and
that NetworkPolicy resources exist with correct pod selectors.

Changes:
- Add namespace constants to helpers.go for reuse across storage tests
- Add storage_networkpolicy.go with tests for CSO and CSI operators
- Verify required network policy labels on deployments
- Validate NetworkPolicy resources in storage namespaces
- Skip these tests on MicroShift clusters where they are not applicable
- Temporarily disabled ManilaCSINamespace check due to OCPBUGS-61175
@duanwei33 duanwei33 changed the title OCPBUGS-64777: Add e2e tests for storage network policy OCPBUGS-64777: [release-4.20] Add e2e tests for storage network policy Nov 10, 2025
@duanwei33 duanwei33 force-pushed the storage-networkpolicy-e2e-4.20 branch from 85767d2 to 7313ec8 Compare November 10, 2025 01:54
@duanwei33 duanwei33 mentioned this pull request Nov 10, 2025
Closed
@duanwei33
Copy link
Contributor Author

duanwei33 commented Nov 10, 2025

/retest-required

@duanwei33
Copy link
Contributor Author

duanwei33 commented Nov 10, 2025

@dobsonj @jsafrane
Could you help check the cherry-pick PR?

@dobsonj
Copy link
Member

dobsonj commented Nov 10, 2025

/lgtm
/approve
/label backport-risk-assessed
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2025

@dobsonj: This PR has been marked as verified by CI.

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

@dobsonj: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers]

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@duanwei33
Copy link
Contributor Author

duanwei33 commented Nov 11, 2025

Needs approval from an approver in each of these files:
test/extended/storage/OWNERS [dobsonj]
test/extended/util/annotate/generated/OWNERS

@jsafrane Are you in team-leads group?

cat test/extended/util/annotate/generated/OWNERS
reviewers:
  - team-leads
approvers:
  - team-leads

@Phaow
Copy link
Contributor

Phaow commented Nov 11, 2025

@duanwei33 @jsafrane is in team-leads group ^^
https://github.com/openshift/origin/blob/main/OWNERS_ALIASES#L38
Let's wait for his approve.

@jsafrane
Copy link
Contributor

jsafrane commented Nov 18, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, duanwei33, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 1d3ad0d and 2 for PR HEAD 7313ec8 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2025

/retest-required

Remaining retests: 0 against base HEAD 0a0905d and 1 for PR HEAD 7313ec8 in total

@jsafrane
Copy link
Contributor

jsafrane commented Nov 25, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2025

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@duanwei33
Copy link
Contributor Author

duanwei33 commented Nov 26, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@duanwei33: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 7313ec8 link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dc5b8e7 into openshift:release-4.20 Nov 26, 2025
19 of 20 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@duanwei33: Jira Issue Verification Checks: Jira Issue OCPBUGS-64777
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64777 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Cherry-pick of #30359 to release-4.20

Summary

Add e2e tests for storage network policy labels. The automatic cherry-pick failed in the /verify CI job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@dobsonj dobsonj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@duanwei33 @openshift-ci-robot @dobsonj @Phaow @jsafrane