Skip to content

OCPBUGS-63307: Add ConfigDriftMonitorStoppedTooOften matcher #30474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-63307: Add ConfigDriftMonitorStoppedTooOften matcher #30474

wants to merge 1 commit into from
+23 −0

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Nov 11, 2025

Add ConfigDriftMonitorStoppedTooOften matcher for image signature validation tests. Fix the run failure

8 events happened too frequently

event happened 24 times, something is wrong: node/ci-op-7b9qs4mj-863c8-hkhwh-worker-a-bm2wt hmsg/8a96eaa4fd - reason/ConfigDriftMonitorStopped Config Drift Monitor stopped (19:47:32Z) result=reject

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@QiWang19: This pull request references Jira Issue OCPBUGS-63307, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add ConfigDriftMonitorStoppedTooOften matcher for image signature validation tests. Fix the run failure

8 events happened too frequently

event happened 24 times, something is wrong: node/ci-op-7b9qs4mj-863c8-hkhwh-worker-a-bm2wt hmsg/8a96eaa4fd - reason/ConfigDriftMonitorStopped Config Drift Monitor stopped (19:47:32Z) result=reject

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 11, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/33fb8b60-bf1f-11f0-8e20-9cdfe664fb9f-0

@openshift-ci openshift-ci bot requested review from deads2k and sjenning November 11, 2025 16:55
@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 12, 2025

Asked a question in the jira, but I'm not seeing why this should be sent 25x in a job run.

dgoodwin
dgoodwin requested changes Nov 18, 2025
View reviewed changes
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go Outdated
func newConfigDriftMonitorStoppedTooOftenEventMatcher(finalIntervals monitorapi.Intervals) EventMatcher {
configDriftMonitorStoppedIntervals := finalIntervals.Filter(func(eventInterval monitorapi.Interval) bool {
return eventInterval.Source == monitorapi.SourceE2ETest &&
strings.Contains(eventInterval.Locator.Keys[monitorapi.LocatorE2ETestKey], "imagepolicy signature validation")
Copy link
Contributor

@dgoodwin dgoodwin Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of your tests match this string. Perhaps match on SigstoreImageVerification, and only limit to +/- 30s rather than 10 minutes. This should give a very precise ignore for ConfigDriftMonitorStopped events overlapping with any of your tests.

@QiWang19
OCPBUGS-63307: Add ConfigDriftMonitorStoppedTooOften matcher
ec0d7f4 
Add ConfigDriftMonitorStoppedTooOften matcher for image signature validation tests. Fix the run failure

```
8 events happened too frequently

event happened 24 times, something is wrong: node/ci-op-7b9qs4mj-863c8-hkhwh-worker-a-bm2wt hmsg/8a96eaa4fd - reason/ConfigDriftMonitorStopped Config Drift Monitor stopped (19:47:32Z) result=reject
```

Signed-off-by: Qi Wang <[email protected]>
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 18, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bf298370-c4bc-11f0-9621-93026fb421ac-0

@openshift-trt
Copy link

openshift-trt bot commented Nov 18, 2025

Job Failure Risk Analysis for sha: ec0d7f4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (12) are below the historical average (2160): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 19, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 19, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 20, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16348310-c632-11f0-93f3-e7a2c4001620-0

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 21, 2025

/verified by payload-job https://pr-payload-tests.ci.openshift.org/runs/ci/16348310-c632-11f0-93f3-e7a2c4001620-0

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@QiWang19: This PR has been marked as verified by payload-job https://pr-payload-tests.ci.openshift.org/runs/ci/16348310-c632-11f0-93f3-e7a2c4001620-0.

In response to this:

/verified by payload-job https://pr-payload-tests.ci.openshift.org/runs/ci/16348310-c632-11f0-93f3-e7a2c4001620-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgoodwin dgoodwin dgoodwin requested changes

@deads2k deads2k Awaiting requested review from deads2k

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@dgoodwin dgoodwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QiWang19 @openshift-ci-robot @dgoodwin