NO-JIRA: net(virt) remove virtctl if not correctly retrieved #30485
Conversation
|
/jira cherry-pick 4.20 |
qinqon
force-pushed
the
kubevirt-remove-virtctl-if-not-correctly-downloaded
branch
from
6c1e12c to
4ea5d93
Compare
|
/payload help |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview |
|
@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3aff56b0-bfdf-11f0-8b16-391e67e12ac3-0 |
qinqon
changed the title
qinqon
changed the title
|
@qinqon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/backport release-4.20 |
|
/cherry-pick release-4.20 |
|
@qinqon: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I am not a huge fan of the fact that we download virtctl directly to |
|
@kyrtapz: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-metal-ipi-ovn-bgp-virt-dualstack |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
/retest-required not related |
openshift-ci
bot
removed
the
do-not-merge/hold
qinqon
force-pushed
the
kubevirt-remove-virtctl-if-not-correctly-downloaded
branch
from
4ea5d93 to
4a6b702
Compare
If the virtctl download/unpack fails in the middle the downloadFile can leave a corrupted file behind, this change ensure file is removed if function do not correctly finish. Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
kubevirt-remove-virtctl-if-not-correctly-downloaded
branch
from
4a6b702 to
3e4f851
Compare
|
/test e2e-metal-ipi-ovn-bgp-virt-dualstack |
|
/retest-required |
|
the vsphere job passed before and the changes in this pr are unrelated: |
|
@kyrtapz: kyrtapz unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Job Failure Risk Analysis for sha: 3e4f851
|
1 similar comment
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
/test e2e-aws-ovn-fips |
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
@qinqon should we link this bug to https://issues.redhat.com/browse/OCPBUGS-65565 ? |
I think that's the 4.20 backport. |
When this merge and backport pops up, then we link it to the jira. |
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
/hold Revision 3e4f851 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@qinqon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Closed it by mistake. |
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
Job Failure Risk Analysis for sha: 3e4f851
|
|
@qinqon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 3e4f851
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 3e4f851
New tests seen in this PR at sha: 3e4f851
|
|
Job Failure Risk Analysis for sha: 3e4f851
|
7 participants
If the virtctl download/unpack fails in the middle the downloadFile can leave a corrupted file behind, this change ensure file is removed if function do not correctly finish.