[release-4.15] OCPBUGS-30899: use a forked version of j-keck/arping that fixes a threading issue

[JacobTanenbaum]

clean cherry-pick of 1aa87b4

here is the PR for the upstream version j-keck/arping#17

using sock.deinitialize() outside of the goroutine that is using the socket leaves the potential for erroneous and unexpected behavior. When calling Ping() very quickly the socket fd can be reused while a goroutine is still trying to read from it and cause the goroutine to deadlock.

removing the sock.deinitialize() from the timeout select case as it will be taken care of by the goroutine upon its return'

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-30899, which is invalid:

• expected the bug to target the "4.15.z" version, but no target version was set
• expected Jira Issue OCPBUGS-30899 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

clean cherry-pick of 1aa87b4

here is the PR for the upstream version j-keck/arping#17

using sock.deinitialize() outside of the goroutine that is using the socket leaves the potential for erroneous and unexpected behavior. When calling Ping() very quickly the socket fd can be reused while a goroutine is still trying to read from it and cause the goroutine to deadlock.

removing the sock.deinitialize() from the timeout select case as it will be taken care of by the goroutine upon its return'

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JacobTanenbaum]

/jira refresh

[openshift-ci-robot]

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-30899, which is invalid:

• expected dependent Jira Issue OCPBUGS-23519 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JacobTanenbaum]

/jira refresh

[openshift-ci-robot]

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-30899, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-23519 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-23519 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JacobTanenbaum]

/retest-required

[trozet]

/label backport-risk-assessed

[trozet]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JacobTanenbaum, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JacobTanenbaum,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[asood-rh]

/label cherry-pick-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7fab1ff and 2 for PR HEAD 9e91936 in total

[openshift-ci]

@JacobTanenbaum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	9e91936	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JacobTanenbaum]

samplers seem to not deploy properly

/retest-required

[openshift-ci-robot]

@JacobTanenbaum: Jira Issue OCPBUGS-30899: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#2105

Jira Issue OCPBUGS-30899 has been moved to the MODIFIED state.

Details

In response to this:

clean cherry-pick of 1aa87b4

here is the PR for the upstream version j-keck/arping#17

using sock.deinitialize() outside of the goroutine that is using the socket leaves the potential for erroneous and unexpected behavior. When calling Ping() very quickly the socket fd can be reused while a goroutine is still trying to read from it and cause the goroutine to deadlock.

removing the sock.deinitialize() from the timeout select case as it will be taken care of by the goroutine upon its return'

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202405162036.p0.gcdc48bb.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-05-18-100250