Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Merge: add cert rotation presubmits to CEO #50445

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Apr 2, 2024

/hold

Reusing the cert rotation shutdown/suspend presubmits for etcd with a time period of 3 years to expire the etcd peer/server certs.

Adding a breakpoint right now to manually test out the recert cmd (openshift/cluster-etcd-operator#1227) to see how we can recover the certs.

/cc @tjungblu

@openshift-ci openshift-ci bot requested a review from tjungblu April 2, 2024 01:38
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hasbro17
Once this PR has been reviewed and has the lgtm label, please assign dinhxuanvu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hasbro17: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-shutdown-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-shutdown-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-shutdown-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-shutdown-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-shutdown-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.14-e2e-metal-ovn-ha-cert-rotation-shutdown-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.14-e2e-metal-ovn-ha-cert-rotation-shutdown-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.14-e2e-metal-ovn-ha-cert-rotation-shutdown-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-ovn-ha-cert-rotation-suspend-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.17-e2e-metal-ovn-ha-cert-rotation-suspend-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-180d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-360d openshift/cluster-kube-apiserver-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-suspend-90d openshift/cluster-kube-apiserver-operator presubmit Registry content changed

A total of 134 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

Let's see how this works.

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

I'm guessing this needs to be a periodic. Edit: Apparently not.

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y

1 similar comment
@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 2, 2024

/retest

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 3, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y

2 similar comments
@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 3, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y

@hasbro17
Copy link
Contributor Author

hasbro17 commented Apr 7, 2024

/pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y

@openshift-ci-robot
Copy link
Contributor

@hasbro17: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@hasbro17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-etcd-operator/release-4.16/e2e-metal-ovn-ha-cert-rotation-shutdown-3y 6e6219e link unknown /pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-shutdown-3y
ci/rehearse/openshift/cluster-etcd-operator/release-4.16/e2e-metal-ovn-sno-cert-rotation-shutdown-3y 6e6219e link unknown /pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-shutdown-3y
ci/rehearse/openshift/cluster-etcd-operator/release-4.16/e2e-metal-ovn-sno-cert-rotation-suspend-3y 6e6219e link unknown /pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-sno-cert-rotation-suspend-3y
ci/rehearse/openshift/cluster-etcd-operator/release-4.16/e2e-metal-ovn-ha-cert-rotation-suspend-3y 6e6219e link unknown /pj-rehearse pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-ovn-ha-cert-rotation-suspend-3y
ci/prow/clusterimageset-validate 6e6219e link true /test clusterimageset-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2024
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2024
@hasbro17 hasbro17 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
4 participants