Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kni: scheduler-plugin: branch out 4.18 and point main to 4.19 #59695

Merged
merged 1 commit into from
Dec 10, 2024
Merged

kni: scheduler-plugin: branch out 4.18 and point main to 4.19 #59695

merged 1 commit into from
Dec 10, 2024

Conversation

shajmakh
Copy link
Contributor

Create 4.18 relevant config and jobs and redirect main to 4.19.

@shajmakh shajmakh force-pushed the sched-branch-out-418 branch from 2d1095a to a60ae71 Compare December 10, 2024 06:40
@shajmakh
kni: scheduler-plugin: branch out 4.18 and point main to 4.19
90c7e47 
Create 4.18 relevant config and jobs and redirect main to 4.19.

Signed-off-by: Shereen Haj <[email protected]>
@shajmakh shajmakh force-pushed the sched-branch-out-418 branch from a60ae71 to 90c7e47 Compare December 10, 2024 06:40
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@shajmakh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-scheduler-plugins-release-4.18-ci-unit openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-release-4.18-images openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-release-4.18-security openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-master-ci-unit openshift-kni/scheduler-plugins presubmit Ci-operator config changed
pull-ci-openshift-kni-scheduler-plugins-master-images openshift-kni/scheduler-plugins presubmit Ci-operator config changed
pull-ci-openshift-kni-scheduler-plugins-master-security openshift-kni/scheduler-plugins presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@shajmakh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-scheduler-plugins-release-4.18-ci-unit openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-release-4.18-images openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-release-4.18-security openshift-kni/scheduler-plugins presubmit Presubmit changed
pull-ci-openshift-kni-scheduler-plugins-master-ci-unit openshift-kni/scheduler-plugins presubmit Ci-operator config changed
pull-ci-openshift-kni-scheduler-plugins-master-images openshift-kni/scheduler-plugins presubmit Ci-operator config changed
pull-ci-openshift-kni-scheduler-plugins-master-security openshift-kni/scheduler-plugins presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

ffromani
ffromani reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@shajmakh
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@shajmakh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@shajmakh
Copy link
Contributor Author

/label rehearsals-ack

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@shajmakh: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ffromani
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@shajmakh
Copy link
Contributor Author

needs openshift-kni/scheduler-plugins#233

@ffromani
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@ffromani
Copy link
Contributor

/pj-rehearse pull-ci-openshift-kni-scheduler-plugins-release-4.18-security

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ffromani
Copy link
Contributor

/pj-rehearse pull-ci-openshift-kni-scheduler-plugins-master-security

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ffromani
Copy link
Contributor

/pj-rehearse ack

(Xref: #59695 (comment))

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8fc3d51 into openshift:master Dec 10, 2024
21 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@shajmakh: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_openshift-kni_quay using file core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay

In response to this:

Create 4.18 relevant config and jobs and redirect main to 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
@shajmakh @yingzhanredhat
kni: scheduler-plugin: branch out 4.18 and point main to 4.19 (opensh…
efa355a 
…ift#59695)

Create 4.18 relevant config and jobs and redirect main to 4.19.

Signed-off-by: Shereen Haj <[email protected]>
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
@shajmakh @yingzhanredhat
kni: scheduler-plugin: branch out 4.18 and point main to 4.19 (opensh…
ad22190 
…ift#59695)

Create 4.18 relevant config and jobs and redirect main to 4.19.

Signed-off-by: Shereen Haj <[email protected]>
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
@shajmakh @krishvoor
kni: scheduler-plugin: branch out 4.18 and point main to 4.19 (opensh…
c76f97a 
…ift#59695)

Create 4.18 relevant config and jobs and redirect main to 4.19.

Signed-off-by: Shereen Haj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shajmakh @openshift-ci-robot @ffromani