Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused build_root #60259

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

liangxia
Copy link
Member

@liangxia liangxia commented Jan 2, 2025

build_root is needed when we build images. As those config files only mean for e2e/upgrade tests, it's safe to remove it.

@openshift-ci openshift-ci bot requested review from gpei and memodi January 2, 2025 06:38
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liangxia: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-azure-ipi-oidc-managed-identity-system-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-aws-upi-reboot-nodes-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.14-azure-ipi-private-network-type-basic-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-aws-ipi-shared-phz-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-azure-ipi-custom-nsg-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-azure-ipi-vmgenv2-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.14-azure-ipi-marketplace-image-gen1-vm-type-gen1-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-arm-f28-ota N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-azure-ipi-arm-f28-ota N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-osimage-customized-reboot-nodes-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-azure-ipi-private-network-type-basic-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-vsphere-ipi-customized-resource-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-aws-ipi-byo-iam-profile-master-arm-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-ibmcloud-ipi-subnet-paging-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-multi-clusters-one-phz-arm-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-vsphere-ipi-disktype-eagerzeroedthick-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-ibmcloud-ipi-private-sshkey-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-aws-ipi-arm-f28-ota N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-azure-ipi-disktype-worker-standard-lrs-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-azure-ipi-mixed-apiserver-ingress-external-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-shared-phz-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.17-aws-ipi-arm-f28-ota N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.14-azure-ipi-disktype-standardssd-lrs-disksize-f28 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-azure-ipi-fullyprivate-firewall-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-vsphere-ipi-disktype-thick-f28 N/A periodic Ci-operator config changed

A total of 220 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@liangxia
Copy link
Member Author

liangxia commented Jan 2, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-azure-ipi-vmgenv2-f14

@openshift-ci-robot
Copy link
Contributor

@liangxia: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liangxia
Copy link
Member Author

liangxia commented Jan 2, 2025

/cc @jianlinliu @anpingli @QiaolingTang

@liangxia
Copy link
Member Author

liangxia commented Jan 2, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@liangxia: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 2, 2025
@liangxia
Copy link
Member Author

liangxia commented Jan 6, 2025

Bump up for attention.

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@liangxia: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 95d0018 into openshift:master Jan 6, 2025
14 checks passed
@liangxia liangxia deleted the remove-buildroot branch January 6, 2025 02:03
Phaow pushed a commit to Phaow/release that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants