Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperShift: Adjust agent CI job name #60274

Merged

Conversation

LiangquanLi930
Copy link
Member

@LiangquanLi930 LiangquanLi930 commented Jan 2, 2025

Adjust the agent's job name to support API server testing, as their code requires the job name to include "-metal-".
Link: https://redhat-internal.slack.com/archives/CFP6ST0A3/p1735806908183919
https://issues.redhat.com/browse/OCPBUGS-47789

@openshift-ci openshift-ci bot requested review from csrwng and sjenning January 2, 2025 13:10
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LiangquanLi930: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.15-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.15-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-compact-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-oadp N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.15-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.15-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-conformance N/A periodic Periodic changed

A total of 27 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@bryan-cox
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, LiangquanLi930, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@LiangquanLi930
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 62de330 into openshift:master Jan 6, 2025
14 of 15 checks passed
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@LiangquanLi930: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Phaow pushed a commit to Phaow/release that referenced this pull request Jan 10, 2025
@LiangquanLi930 LiangquanLi930 deleted the adjust-agent-name branch January 14, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants