TRT-1702: Risk Analysis: ensure Test ID is populated #1852

sosiouxme · 2024-07-11T21:41:28Z

At the time that openshift-e2e-tests requests it, test results haven't yet been associated with test IDs (we just have junits). So it is posting a ProwJobRun with partial Test records to the API, sans IDs. This PR changes the past-results queries by test name to also return the test ID, and uses that to populate RA results.

Messing with the queries worries me a little; every instance of a test name I saw only had a single test ID across multiple jobs, but I'm not certain that's reliable, so check me.

openshift-ci-robot · 2024-07-11T21:41:32Z

@sosiouxme: This pull request references TRT-1702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Depending on how the RA request is formed, the Test record that comes back may not have its ID. This is the case for how openshift-e2e-tests requests it - by posting a ProwJobRun with incomplete Test records to the API. In that case, look it up from the RA results, one of which ought to have it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-07-11T21:42:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sosiouxme
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-07-11T23:38:20Z

@sosiouxme: This pull request references TRT-1702 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

At the time that openshift-e2e-tests requests it, test results haven't yet been associated with test IDs (we just have junits). So it is posting a ProwJobRun with partial Test records to the API, sans IDs. This PR changes the past-results queries by test name to also return the test ID, and uses that to populate RA results.

Messing with the queries worries me a little; every instance of a test name I saw only had a single test ID across multiple jobs, but I'm not certain that's reliable, so check me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

neisw · 2024-07-17T15:26:37Z

pkg/api/tests.go

 	processedResults := dbc.DB.Table("(?) as results", rawQuery).
-		Select(`ROW_NUMBER() OVER() as id, watchlist, name, jira_component, jira_component_id,` + variantSelect + query.QueryTestSummarizer).
+		Select(`id, watchlist, name, jira_component, jira_component_id,` + variantSelect + query.QueryTestSummarizer).


This is likely worth additional review. I'm wondering if there was a reason id wasn't used before and if this impacts other parts of the UI like the tests report.

Could select id as test_id and then keep the existing ROW_NUMBER() OVER() statement. Don't know that we need it but if we wanted to keep the query as it was and just add in the test id.

from the deleted FIXME comment and the state of the matview, i gathered this was written at a point where the test id didn't exist in the view, and so ROW_NUMBER was just a stand-in so there would be something, with the intent to go back and update the matview and the query. well, the matview got updated with a test id, but the query never did until this.

Looks like apitype.Test expects ID to be a float64:

sippy/pkg/apis/api/types.go

Line 535 in cc0ba0e

return float64(test.ID), nil

/hold
the tests report is using the "synthetic" id and it gets the table wrong if results repeat the same id. that seems like an abuse of Test.ID to me but i suppose we can work around it.

no idea what the float64 cast is for but we can leave Test.ID to its current purpose and look up the real test id in a new field.

At the time that openshift-e2e-tests requests RA, test results haven't yet been associated with test IDs (we just have junits). So it is posting a `ProwJobRun` with partial `Test` records to the API, sans IDs. This PR changes the past-results queries by test name to also return the test ID, and uses that to populate RA results.

neisw · 2024-07-29T14:51:22Z

pkg/apis/api/types.go

@@ -757,7 +758,7 @@ type ProwJobRunRiskAnalysis struct {

 type ProwJobRunTestRiskAnalysis struct {
 	Name     string
-	TestID   uint
+	TestID   string


Curious how this will play out with the autodl table. We currently have TestID as an int. We can delete those tables and start over but if you think we will keep an int value and add the 'unique' string id maybe we should add a new string field here instead? I wonder if TestUniqueId or similar is a good identifier, like what you have in:

town.unique_id as test_str_id,

openshift-ci · 2024-07-31T13:24:48Z

@sosiouxme: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	`5dcaa3b`	link	true	`/test e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-11-06T01:00:37Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot · 2024-11-06T01:00:49Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-12-06T08:30:48Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2025-01-06T00:01:02Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2025-01-06T00:01:41Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2024

openshift-ci bot requested review from DennisPeriquet and neisw July 11, 2024 21:42

sosiouxme force-pushed the 20240711-fix-test-id branch from 6c547f6 to fd4747d Compare July 11, 2024 23:31

sosiouxme force-pushed the 20240711-fix-test-id branch from fd4747d to 08cb762 Compare July 11, 2024 23:39

neisw reviewed Jul 17, 2024

View reviewed changes

sosiouxme added 3 commits July 22, 2024 18:08

serve.go: add debuggable entry point

70bbde5

debug: raise db logging

c969e6c

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2024

sosiouxme added 2 commits July 28, 2024 15:12

include string test_id in analysis matviews

c9b4659

WIP consume string test_id

7f29fb9

sosiouxme force-pushed the 20240711-fix-test-id branch from 08cb762 to 7f29fb9 Compare July 29, 2024 12:50

neisw reviewed Jul 29, 2024

View reviewed changes

sosiouxme added 2 commits July 29, 2024 16:54

back to int test ids

a75cdcf

not all test ids have string equivalents

5dcaa3b

sosiouxme marked this pull request as draft August 7, 2024 19:20

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2024

openshift-ci bot closed this Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRT-1702: Risk Analysis: ensure Test ID is populated #1852

TRT-1702: Risk Analysis: ensure Test ID is populated #1852

sosiouxme commented Jul 11, 2024 •

edited

Loading

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Jul 11, 2024

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading

neisw Jul 17, 2024

neisw Jul 17, 2024

sosiouxme Jul 17, 2024

neisw Jul 17, 2024

sosiouxme Jul 28, 2024

neisw Jul 29, 2024

openshift-ci bot commented Jul 31, 2024

openshift-bot commented Nov 6, 2024

openshift-merge-robot commented Nov 6, 2024

openshift-bot commented Dec 6, 2024

openshift-bot commented Jan 6, 2025

openshift-ci bot commented Jan 6, 2025

TRT-1702: Risk Analysis: ensure Test ID is populated #1852

TRT-1702: Risk Analysis: ensure Test ID is populated #1852

Conversation

sosiouxme commented Jul 11, 2024 • edited Loading

openshift-ci-robot commented Jul 11, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Jul 11, 2024

openshift-ci-robot commented Jul 11, 2024 • edited by openshift-ci bot Loading

neisw Jul 17, 2024

Choose a reason for hiding this comment

neisw Jul 17, 2024

Choose a reason for hiding this comment

sosiouxme Jul 17, 2024

Choose a reason for hiding this comment

neisw Jul 17, 2024

Choose a reason for hiding this comment

sosiouxme Jul 28, 2024

Choose a reason for hiding this comment

neisw Jul 29, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Jul 31, 2024

openshift-bot commented Nov 6, 2024

openshift-merge-robot commented Nov 6, 2024

openshift-bot commented Dec 6, 2024

openshift-bot commented Jan 6, 2025

openshift-ci bot commented Jan 6, 2025

sosiouxme commented Jul 11, 2024 •

edited

Loading

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading