Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple domain names #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twofatmonkeys
Copy link

Added bash to the Docker image, modified scripts to use the bash shebang and support a comma separated DOMAIN_NAME variable whilst maintaining backwards compatibility.

Added bash to the Docker image, modified scripts to use the bash shebang and support a comma separated DOMAIN_NAME variable whilst maintaining backwards compatibility.
@openspeedtest
Copy link
Owner

Have you tested this? How does the Nginx server handle the certificate? If you need to run this on separate domain names, run three different instances on different servers that are used for those services. That's better than hosting all domains on one server.

@twofatmonkeys
Copy link
Author

Have you tested this? How does the Nginx server handle the certificate? If you need to run this on separate domain names, run three different instances on different servers that are used for those services. That's better than hosting all domains on one server.

Yes, tested both the Docker build and the scripts and we're running now in production with our existing single domain certificate updated seamlessly with just a change to DOMAIN_NAME. We have a build available in docker hub at twofatmonkeys/openspeedtest:latest.

Nginx handles the certificate just like any other SAN certificate, the script adds all the domains to the server statement and uses only the first domain for file naming purposes. It is backwards compatible with any existing configs and just adds additional functionality.

As a service provider the main purpose of this for us is to have the option to force IPv4 or IPv6 via the domain names for troubleshooting. Adding separate instances seemed unnecessary and a waste of resources to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants