Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SDC Version #3703

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Upgrade SDC Version #3703

merged 4 commits into from
Jan 31, 2025

Conversation

ndegwamartin
Copy link
Contributor

Fixes bug with PR google/android-fhir#2645

FikriMilano
FikriMilano previously approved these changes Jan 23, 2025
@FikriMilano FikriMilano dismissed their stale review January 23, 2025 14:30

Let me try this tomorrow

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.5%. Comparing base (e501d27) to head (34d7f85).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3703     +/-   ##
=========================================
- Coverage     39.1%   38.5%   -0.6%     
- Complexity    1167    1171      +4     
=========================================
  Files          284     286      +2     
  Lines        15090   15264    +174     
  Branches      2671    2694     +23     
=========================================
- Hits          5904    5891     -13     
- Misses        8341    8525    +184     
- Partials       845     848      +3     
Flag Coverage Δ
engine 62.7% <ø> (-0.3%) ⬇️
geowidget 16.0% <ø> (ø)
quest 24.5% <ø> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

FikriMilano
FikriMilano previously approved these changes Jan 27, 2025
Copy link
Collaborator

@FikriMilano FikriMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pld pld added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@dubdabasoduba dubdabasoduba merged commit 4ddd5db into main Jan 31, 2025
5 checks passed
@dubdabasoduba dubdabasoduba deleted the minor-fix-sdc branch January 31, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants