Skip to content

install cephadm on all nodes#3552

Merged
amartyasinha merged 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:fix_missing_packages_in_cephnodes
Feb 3, 2026
Merged

install cephadm on all nodes#3552
amartyasinha merged 1 commit into
openstack-k8s-operators:mainfrom
katarimanojk:fix_missing_packages_in_cephnodes

Conversation

@katarimanojk

@katarimanojk katarimanojk commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from 2241460 to 0c9047f Compare December 12, 2025 14:28
katarimanojk
katarimanojk commented Dec 12, 2025
View reviewed changes
Comment thread hooks/playbooks/ceph.yml Outdated
fmount
fmount reviewed Dec 12, 2025
View reviewed changes
Comment thread hooks/playbooks/ceph.yml Outdated
@github-actions

github-actions Bot commented Dec 28, 2025

Copy link
Copy Markdown

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Dec 28, 2025
@github-actions github-actions Bot closed this Jan 4, 2026
@katarimanojk katarimanojk removed the Stale label Jan 5, 2026
@katarimanojk katarimanojk reopened this Jan 5, 2026
@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from 0c9047f to a27c4f4 Compare January 5, 2026 05:37
fultonj
fultonj reviewed Jan 12, 2026
View reviewed changes

@fultonj fultonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please consider a few small changes?

Comment thread hooks/playbooks/ceph.yml Outdated
@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from a27c4f4 to e90853a Compare January 19, 2026 13:12
@katarimanojk katarimanojk requested a review from fultonj January 19, 2026 13:22
fmount
fmount reviewed Jan 19, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor things that we can even address in a follow up, the patch seems good to go. @katarimanojk let me know if you have other iterations on it, otherwise we can land it.

Comment thread hooks/playbooks/ceph.yml Outdated
Comment thread hooks/playbooks/ceph.yml Outdated
@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from e90853a to 483825e Compare January 20, 2026 07:38
@katarimanojk

katarimanojk commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Other than minor things that we can even address in a follow up, the patch seems good to go. @katarimanojk let me know if you have other iterations on it, otherwise we can land it.

@fmount Thanks for the suggestions, updated the patch now

@katarimanojk katarimanojk requested a review from fmount January 20, 2026 07:39
fmount
fmount previously approved these changes Jan 20, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread hooks/playbooks/ceph.yml
@openshift-ci openshift-ci Bot added the lgtm label Jan 20, 2026
@fmount

fmount commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

@katarimanojk as per the recent failures I'm wondering if this patch should be extended to install not only cephadm but also the missing requirements [1].

[1] https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/cifmw_block_device/tasks/main.yml#L23

@fmount

fmount commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jan 29, 2026
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Jan 29, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7404c62f4eae4372badea8c7438ce04f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 40m 17s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 05m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 13s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 13m 56s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 56m 04s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 53s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 13s

@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from 3dcaa11 to eb93a7b Compare January 30, 2026 09:55
@openshift-ci openshift-ci Bot removed the lgtm label Jan 30, 2026
@softwarefactory-project-zuul

softwarefactory-project-zuul Bot commented Jan 30, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d49ad24d21644228bb9baf541ff95694

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 26s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 22m 34s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 1h 54m 25s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 47m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 05s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 33s

@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from eb93a7b to e48111a Compare February 2, 2026 10:18
fmount
fmount previously approved these changes Feb 2, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 2, 2026
fultonj
fultonj reviewed Feb 2, 2026
View reviewed changes
Comment thread hooks/playbooks/ceph.yml Outdated
@fultonj fultonj requested a review from rebtoor February 2, 2026 21:22
@katarimanojk
[cifmw_cephadm] Add ceph prerequisites play to install cephadm on all…
7086d8f 
… nodes

For adoption scenarios with external Ceph, cephadm and dependent packages
may be missing on nodes. Add separate play to install required packages on
all nodes.

Signed-off-by: mkatari <mkatari@redhat.com>
Jira: OSPRH-24863
@katarimanojk katarimanojk force-pushed the fix_missing_packages_in_cephnodes branch from e48111a to 7086d8f Compare February 3, 2026 09:02
@openshift-ci openshift-ci Bot removed the lgtm label Feb 3, 2026
fmount
fmount approved these changes Feb 3, 2026
View reviewed changes

@fmount fmount left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 3, 2026
@fultonj

fultonj commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@fultonj fultonj dismissed rebtoor’s stale review February 3, 2026 13:00

The requested changes have been made.

fultonj
fultonj approved these changes Feb 3, 2026
View reviewed changes

@fultonj fultonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Feb 3, 2026
@amartyasinha amartyasinha merged commit d526d3e into openstack-k8s-operators:main Feb 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fultonj fultonj fultonj approved these changes
@fmount fmount fmount approved these changes
@amartyasinha amartyasinha amartyasinha approved these changes
@rebtoor rebtoor Awaiting requested review from rebtoor

Assignees

@fultonj fultonj

@fmount fmount

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@katarimanojk @fmount @michburk @fultonj @rebtoor @amartyasinha