[cifmw_helpers] Remove tempfile after including file in cifmw_helpers#3646
Merged
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There is a bug, that when include_file is used, it creates a temporary directory, but after all is done, it is not removed, because temporary dir was done using delegation, and removing without it. By adding delegation, the temporary dir which is created also on delegated host, should be available and can be removed. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
remove-temp-dir
branch
from
ab56d74 to
85f2ce4
Compare
danpawlik
changed the title
amartyasinha
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug, that when include_file is used, it creates a temporary directory, but after all is done, it is not removed, because temporary dir was done using delegation, and removing without it. By adding delegation, the temporary dir which is created also on delegated host, should be available and can be removed.