[update] Add optional cleanup of OpenStack resources#4023
Open
mnietoji wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
956154a to
f8194fc
Compare
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
f8194fc to
4bc9d77
Compare
michburk
reviewed
Jul 1, 2026
michburk
left a comment
michburk
left a comment
Contributor
There was a problem hiding this comment.
two small things to consider, largely lgtm
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
4bc9d77 to
0c7140f
Compare
The update role creates test workloads (ping test VM, ports) on OpenStack during the update procedure but never cleans them up. This leaves ports allocated on the external network, which blocks subsequent test jobs from recreating subnets. Add a cleanup step at the end of the update role that runs the workload_launch.sh script in cleanup mode to delete the test VM and associated ports. The cleanup runs by default and can be disabled with cifmw_update_dont_cleanup for debugging. Based on the work from openstack-k8s-operators#3335 by Sofer Athlan-Guyot which was closed by the stale bot before merging. Related-Issue: #OSPRH-20307 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
mnietoji
force-pushed
the
update-cleanup-resources
branch
from
0c7140f to
60b3eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update role creates test workloads (ping test VM, ports) on OpenStack during the update procedure but never cleans them up. This leaves ports allocated on the external network, which blocks subsequent test jobs from recreating subnets.
Add a cleanup step at the end of the update role that runs the workload_launch.sh script in cleanup mode to delete the test VM and associated ports. The cleanup runs by default and can be disabled with cifmw_update_dont_cleanup for debugging.
Based on the work from #3335 by Sofer Athlan-Guyot which was closed by the stale bot before merging.
Related-Issue: #OSPRH-20307