Skip to content

ovn-agent needs access to /run/frr to get access to vtysh socket#1195

Merged
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
mtomaska:vty_socket
Jul 3, 2026
Merged

ovn-agent needs access to /run/frr to get access to vtysh socket#1195
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
mtomaska:vty_socket

Conversation

@mtomaska

@mtomaska mtomaska commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The ovn-agent container needs to share /run/frr volume with the running the frr container.
This is to get access to the frr socket.

JIRA: https://redhat.atlassian.net/browse/OSPRH-31097

Related to openstack-k8s-operators/tcib#398

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cubeek

cubeek commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

It would be great if we can create a dedicated volume and then mount the volume to both ovn-agent and FRR. Exposing the VTY socket to the hypervisor filesystem could be potentially a security risk?

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 16, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a4f1c135131b455e9b1ea0ce33c8d858

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 41m 59s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 08s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 46m 05s
✔️ noop SUCCESS in 0s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 39m 59s
❌ edpm-ansible-baremetal-minor-update RETRY_LIMIT in 20m 01s

@mtomaska mtomaska marked this pull request as ready for review June 17, 2026 23:18
@openshift-ci openshift-ci Bot requested review from karelyatin and slawqo June 17, 2026 23:18
@mtomaska mtomaska requested review from cubeek and removed request for slawqo June 17, 2026 23:18
@mtomaska mtomaska force-pushed the vty_socket branch 2 times, most recently from 6829946 to 86d4f9c Compare June 23, 2026 19:36
@mtomaska

mtomaska commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

recheck

eduolivares
eduolivares reviewed Jun 24, 2026
View reviewed changes
Comment thread roles/edpm_neutron_ovn/molecule/common/prepare_frr.yml Outdated
@mtomaska mtomaska marked this pull request as draft June 25, 2026 13:34
@mtomaska mtomaska force-pushed the vty_socket branch 5 times, most recently from 847b99e to 6ab132d Compare June 25, 2026 17:19
@mtomaska mtomaska marked this pull request as ready for review June 25, 2026 17:59
@openshift-ci openshift-ci Bot requested review from slawqo and stuggi June 25, 2026 17:59
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/9f40153192584aa0bf32e1a513af335a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 31m 26s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 45m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 08s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 37m 32s
✔️ noop SUCCESS in 0s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 41m 01s
✔️ edpm-ansible-baremetal-minor-update SUCCESS in 2h 13m 08s
✔️ edpm-ansible-molecule-edpm_neutron_ovn SUCCESS in 20m 02s

karelyatin
karelyatin approved these changes Jun 26, 2026
View reviewed changes

@karelyatin karelyatin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 26, 2026
@eduolivares

eduolivares commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

recheck

mtomaska added 3 commits July 3, 2026 11:38
@mtomaska @eduolivares
Move molecule test to zuul in preparation to run add new tests which
993bcb1 
can not be run in a podman container
@mtomaska @eduolivares
Add ovn agent evpn extension config variables
c4b0732 
Sets `bgp_as`, `bgp_local_interface`, `child_vxlan_port` and
`frr_vty_socket` under [ovn_evpn] section for the ovn-agent config.
It sets Open_vswitch table external ids required by OVN
agent evpn extension. Lastly, it loads vrf kernel module needed for
frr service
@mtomaska @eduolivares
Ovn-agent needs access to /run/frr to get access to vtysh socket
14bae99
@openshift-ci openshift-ci Bot added approved and removed lgtm labels Jul 3, 2026
@eduolivares

eduolivares commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I simply rebased Miro's branch to force re-executing zuul jobs because one of them had failed with NODE_FAILURE.

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/a1773263d66e4dada2d1bf2f5ca899ae

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 35m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 41s
❌ cifmw-crc-podified-edpm-baremetal NODE_FAILURE Node(set) request 099-0000134269 failed in 0s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 06s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 2h 11m 56s
✔️ noop SUCCESS in 0s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 59m 08s
✔️ edpm-ansible-baremetal-minor-update SUCCESS in 2h 14m 55s
✔️ edpm-ansible-molecule-edpm_neutron_ovn SUCCESS in 21m 36s

@eduolivares

eduolivares commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

recheck

@openshift-ci openshift-ci Bot added the lgtm label Jul 3, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eduolivares, karelyatin, mtomaska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8a04184 into openstack-k8s-operators:main Jul 3, 2026
34 checks passed
@eduolivares

eduolivares commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick 18.0-fr6

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Jul 6, 2026

Copy link
Copy Markdown

@eduolivares: new pull request created: #1211

Details

In response to this:

/cherry-pick 18.0-fr6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karelyatin karelyatin karelyatin approved these changes
@eduolivares eduolivares eduolivares approved these changes
@cubeek cubeek Awaiting requested review from cubeek
@slawqo slawqo Awaiting requested review from slawqo
@stuggi stuggi Awaiting requested review from stuggi

Assignees

@karelyatin karelyatin

@eduolivares eduolivares

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtomaska @cubeek @eduolivares @openshift-cherrypick-robot @karelyatin