Fix client IP logging in Horizon VirtualHost#612
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 30, 2026
Conversation
The VirtualHost CustomLog directive was using a custom format that only logged forwarded requests, missing direct requests entirely. Replace with SetEnvIf and dual CustomLog lines to match the nova-operator pattern, logging both direct and forwarded requests with the correct client IP. Closes: OSPRH-32110 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 9c20eb3
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VirtualHostCustomLogdirective was overriding the server-level dual-log setup, causing all requests to be logged with the OpenShift router IP instead of the real client IP fromX-Forwarded-For.Add
SetEnvIfand dualCustomLoglines inside theVirtualHostblock to match thenova-operatorpattern.Jira: OSPRH-32110