Only enable AMQP proxy for Mirrored to Quorum queue migration - #648
Open
lmiccini wants to merge 1 commit into
Open
Conversation
The proxy sidecar was incorrectly enabled for all 3.x→4.x RabbitMQ upgrades, even when clusters were already using Quorum queues. The proxy is only needed when migrating from Mirrored to Quorum queues to handle the durability semantics difference during the transition. Add Status.QueueType == Mirrored check to the isVersionUpgradeWithMigration condition so version-only upgrades on existing Quorum clusters skip the unnecessary proxy sidecar. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lmiccini
changed the title
lmiccini
added
do-not-merge/hold
do-not-merge/work-in-progress
and removed
do-not-merge/hold
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy sidecar was incorrectly enabled for all 3.x -> 4.x RabbitMQ upgrades, even when clusters were already using Quorum queues. The proxy is only needed when migrating from Mirrored to Quorum queues to handle the durability semantics difference during the transition.
Add Status.QueueType == Mirrored check to the isVersionUpgradeWithMigration condition so version-only upgrades on existing Quorum clusters skip the unnecessary proxy sidecar.