Remove deprecated extra gui_qt from setup.cfg#1704
Conversation
dcda3f0 to
6f1b715
Compare
mkrnr
left a comment
There was a problem hiding this comment.
LGTM 👍
Also did a quick test on the PySide6 branch and removing this didn't seem to have any impact.
Feel free to merge the PR.
|
This change seems to break the build on MacOS (at least locally for me), causing the |
|
(Is this PySide6 branch up anywhere, out of interest?) |
|
Understandable, given Plover uses quite a lot of See also #1703 Given the above, and the fact that dependency on entry point itself is going to be deprecated, it's probably sufficient if we just remove the relevant check. (The PySide6 branch is at #1601 . ) |
…r the `UnknownExtra` error. References opensteno/plover#1704.
According to pypa/setuptools#4862 , specifying extra for entrypoint is deprecated. And as I explained there, it breaks some features (in particular if that is used then gui_qt no longer work on my machine).
The simplest way seems to be just remove the extra specification.
Pull Request Checklist