sotm: use a bundler cache for kitchen runs #538
Conversation
|
FYI |
|
20 minutes fast! :-) |
Firefishy
force-pushed
the
sotm-cache-bundler-in-kitchen
branch
from
ab11de4 to
965d77c
Compare
| cwd "/srv/#{year}.stateofthemap.org/vendor" | ||
| only_if { kitchen? } | ||
| only_if { ::Dir.exist?("/srv/#{year}.stateofthemap.org/vendor/bundle") } | ||
| not_if { ::File.exist?("#{Chef::Config[:file_cache_path]}/stateofthemap-gem-bundle-cache.tar") } |
There was a problem hiding this comment.
All these conditions are pointless if the action is :nothing because it's not going to run anyway, and when it is run by notifies they will be ignored.
| overwrite false | ||
| only_if { ::File.exist?("#{Chef::Config[:file_cache_path]}/stateofthemap-gem-bundle-cache.tar") } | ||
| not_if { ::Dir.exist?("/srv/#{year}.stateofthemap.org/vendor/bundle") } | ||
| only_if { kitchen? } |
There was a problem hiding this comment.
Why limit it to when running under kitchen? Either it is safe, in which case we can always use it, or it isn't.
Mind if you are caching binaries there would then be questions about invalidating the cache when the dependencies of those binaries change.
Firefishy
force-pushed
the
sotm-cache-bundler-in-kitchen
branch
from
965d77c to
ff6128d
Compare
Firefishy
force-pushed
the
sotm-cache-bundler-in-kitchen
branch
from
ff6128d to
7dbd075
Compare
|
Going to abandon this PR. Going to replace SOTM sites with docker containers built upstream. |
In kitchen cache the
bundle installfrom the first jekyll sotm site and re-use the cache for other sotm runs ofbundle install