Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ticket_validator icon to ticket #1388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matkoniecz
Copy link
Contributor

requested by #1387

would reduce confusion with generic vending machine, increase confusion with machine selling tickets, not sure which is worse

proper fix for #1387 would be a new icon

Description, Motivation & Context

Related issues

none

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

requested by openstreetmap#1387

would reduce confusion with generic vending machine, increase confusion with machine selling tickets, not sure which is worse

proper fix for  openstreetmap#1387 would be a new icon
Copy link

🍱 You can preview the tagging presets of this pull request here.

@dokutan
Copy link

dokutan commented Nov 15, 2024

Test-Documentation

Preview links & Sidebar Screenshots

image

Search

image

Info-i

image

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@dokutan
Copy link

dokutan commented Nov 15, 2024

I personally find this icon an improvement over the old temaki-vending_machine icon.

If ticket validators and ticket vending machines should have different icons, there is the fas-ticket-alt icon (already used for shop=ticket) which could also be used for ticket validators:
image

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Nov 16, 2024

maybe with checkmark superimposed on this? if someone wants to make a new icon

but this may be a bit too crowded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants