Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit" menu shown on (small format) mobile devices largely non-functional #5326

Open
simonpoole opened this issue Nov 15, 2024 · 8 comments · May be fixed by #5351
Open

"Edit" menu shown on (small format) mobile devices largely non-functional #5326

simonpoole opened this issue Nov 15, 2024 · 8 comments · May be fixed by #5351

Comments

@simonpoole
Copy link
Contributor

simonpoole commented Nov 15, 2024

How to reproduce the issue?

Use phone to connect to openstreetmap.org

Screenshot(s) or anything else?

On phone the edit button is now displayed, while it works for iD (if it is useful is a matter of debate), JOSM RC will not work as is at least on Android. See #1478

I suspect this is a regression or at least an unintentional change.

@AntonKhorev
Copy link
Collaborator

I suspect this is a regression

A regression from what? Do you have JOSM running on Android that used to work but now doesn't?

@simonpoole
Copy link
Contributor Author

From the button not being displayed...

@AntonKhorev
Copy link
Collaborator

I assumed we wanted to display the edit button now. There were other pull requests implementing that, like #4839

@matkoniecz
Copy link
Contributor

edit on mobile version is a great idea, but it does not really make sense without links to mobile editors

@simonpoole
Copy link
Contributor Author

edit on mobile version is a great idea, but it does not really make sense without links to mobile editors

It doesn't really need links, the JOSM RC interface is trivial to implement for any Android app, it is just an issue with the way the rails-ports generates the URL.

See #1478

PS: I'm not naive enough to assume that this will happen in any form, naturally everybody will want their own link for marketing purposes.

@matkoniecz
Copy link
Contributor

Would #1478 work also when user has no got any relevant app installed yet?

Maybe I misunderstood how it works but AFAIK not.

PS: I'm not naive enough to assume that this will happen in any form, naturally everybody will want their own link for marketing purposes.

I would prefer edit menu linking on Android to Vespucci and EveryDoor (or EveryDoor only) over the current state.

@simonpoole
Copy link
Contributor Author

Would #1478 work also when user has no got any relevant app installed yet?

As is no, but you could show a popup or similar if nothing was installed (just as it now asks you to start JOSM on desktop), potentially you could offer to directly install an app, but that all gets kind of complicated in more than one way.

The good thing is that you wouldn't have to explicitly start the app once installed.

@AntonKhorev
Copy link
Collaborator

edit on mobile version is a great idea, but it does not really make sense without links to mobile editors

Does enabling iD still counts as "not really making sense"?

@AntonKhorev AntonKhorev linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants