Add josm scheme link to edit menu #5351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
edit-josm-protocol
branch
from
1a8a276
to
948658b
Compare
|
Why on earth is it |
|
Probably because it supports some of the commands that remote control also supports, and remote control is mostly a JOSM thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, Vespucci is registered for
josm:links: https://vespucci.io/tutorials/vespucci_intents/#supported-intentsThis provides an option to run Vespucci as requested by #3836. Fixes #5326.
I'm not yet making it selectable as a preference because we might want to have this equivalent to remote control on Android. That's what #1478 tried to do. The reasoning for this is probably the following. Let's say I set my preferred editor to remote control. Then I open the website on Android. Surely remote control is not going to work there as is. But I still want something to happen when I press edit. How about this thing that I added in this PR?
But there are also reasons against combining this with remote control:
josm:linkshttp://127.0.0.1:8111doesn't work butjosm:does?http://127.0.0.1:8111does work, and we want both it andjosm:?