Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add older/newer links in front of diary, comment, issue, block pages #5262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Oct 15, 2024

For consistency, this adds previous/next page links on the top of every page where it's also at the bottom. See #4646 (comment) for reasoning.

image

Copy link
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great on my side, thank you very much!

Wild idea: since we already have decision procedure, which answers the question "do we have multiple pages?", why don't we use it for hiding pagination buttons when they are not required / usable?

Copy link
Contributor

@nertc nertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly. Every occurrence of "shared/pagination" has its own pair on top of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants