Skip to content

Add older/newer links in front of diary, comment, issue, block pages#5262

Merged
tomhughes merged 1 commit intoopenstreetmap:masterfrom
AntonKhorev:pagination-both-sides
Jun 27, 2025
Merged

Add older/newer links in front of diary, comment, issue, block pages#5262
tomhughes merged 1 commit intoopenstreetmap:masterfrom
AntonKhorev:pagination-both-sides

Conversation

@AntonKhorev
Copy link
Copy Markdown
Collaborator

@AntonKhorev AntonKhorev commented Oct 15, 2024

For consistency, this adds previous/next page links on the top of every page where it's also at the bottom. See #4646 (comment) for reasoning.

image

@AntonKhorev AntonKhorev force-pushed the pagination-both-sides branch 2 times, most recently from 74be3f8 to 0b05331 Compare October 15, 2024 14:39
Copy link
Copy Markdown
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great on my side, thank you very much!

Wild idea: since we already have decision procedure, which answers the question "do we have multiple pages?", why don't we use it for hiding pagination buttons when they are not required / usable?

Copy link
Copy Markdown
Contributor

@nertc nertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly. Every occurrence of "shared/pagination" has its own pair on top of the page.

@AntonKhorev AntonKhorev force-pushed the pagination-both-sides branch 2 times, most recently from fe1f63c to a903621 Compare January 22, 2025 00:01
@AntonKhorev AntonKhorev force-pushed the pagination-both-sides branch from a903621 to 092c8c2 Compare June 26, 2025 14:10
@tomhughes
Copy link
Copy Markdown
Member

Sorry it's taken so long, but this looks good to me, thanks.

@tomhughes tomhughes merged commit b9a37b5 into openstreetmap:master Jun 27, 2025
16 checks passed
@AntonKhorev AntonKhorev deleted the pagination-both-sides branch June 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants