Put api keys directly in js layer definitions #5352
+23
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently map layer API keys have one extra level of indirection:
osm.js.erb
reads them from the settings and writes them toOSM.THUNDERFOREST_KEY
andOSM.TRACESTRACK_KEY
layers.yml
contain names ofOSM
properties to check for keysInstead of this
osm.js.erb
could write keys directly to layer definitions, skippingOSM.THUNDERFOREST_KEY
andOSM.TRACESTRACK_KEY
.layers.yml
could contain the corresponding settings names. The advantage is that Thunderforest and Tracestrack keys are no longer special. A new key can be added just by editingsettings.yml
andlayers.yml
. Also it's possible to skip layer definitions if they require a key and that key is missing.