Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow parsing IPs as hostnames #1999

Merged
merged 6 commits into from
Mar 24, 2025
Merged

fix: Allow parsing IPs as hostnames #1999

merged 6 commits into from
Mar 24, 2025
+26 −9

Conversation

mkleene
Copy link
Contributor

@mkleene mkleene commented Mar 21, 2025 •
edited
Loading

Proposed Changes

  • Also rely more on parsing using net and url libraries as opposed to regex

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

Sorry, something went wrong.

@mkleene mkleene requested review from a team as code owners March 21, 2025 17:42
elizabethhealy
elizabethhealy reviewed Mar 21, 2025
View reviewed changes
@mkleene mkleene enabled auto-merge March 21, 2025 20:44
@mkleene mkleene requested a review from elizabethhealy March 21, 2025 21:27
@mkleene mkleene added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit d54b550 Mar 24, 2025
23 checks passed
@mkleene mkleene deleted the bug/DSPX-372-parse-ip-as-hostname branch March 24, 2025 15:41
@opentdf-automation opentdf-automation bot mentioned this pull request Mar 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethhealy elizabethhealy

@dmihalcik-virtru dmihalcik-virtru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkleene @elizabethhealy @dmihalcik-virtru