[build] allow using shared boost libraries #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
===========================================
- Coverage 55.77% 45.01% -10.77%
===========================================
Files 87 108 +21
Lines 6890 13360 +6470
Branches 0 963 +963
===========================================
+ Hits 3843 6014 +2171
- Misses 3047 7019 +3972
- Partials 0 327 +327 ☔ View full report in Codecov by Sentry. |
|
bump |
Do not unconditionally set `Boost_USE_STATIC_LIBS` but instead default it to `true`. This allows building with shared Boost libraries, which can be useful for OS distribution packaging, for example. The default is the same if not defined, so this is a backwards compatible change: unless explicitly set to `false`, static Boost libs will still be used.
jwhui
force-pushed
the
milas/boost-staticlibs-optout
branch
from
6fcae37 to
f60d1d5
Compare
jwhui
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not unconditionally set
Boost_USE_STATIC_LIBSbut instead default it totrue.This allows building with shared Boost libraries, which can be useful for OS distribution packaging, for example.
The default is the same if not defined, so this is a backwards compatible change: unless explicitly set to
false, static Boost libs will still be used.In particular, this is useful for NixOS, where the static Boost lib will not work.
See also: