Skip to content

[tests] remove stale code in test bootstrap script#2691

Merged
jwhui merged 1 commit intoopenthread:mainfrom
Irving-cl:clean_up_bootstrap
Feb 5, 2025
Merged

[tests] remove stale code in test bootstrap script#2691
jwhui merged 1 commit intoopenthread:mainfrom
Irving-cl:clean_up_bootstrap

Conversation

@Irving-cl
Copy link
Copy Markdown
Contributor

This PR removes the if branch of BUILD_TARGET of 'otbr-dbus-check' in the bootstrap script.

In our CI, there is no such target now. All the targets:

➜  ot-br-posix git:(clean_up_bootstrap) ✗ grep -rnI --exclude-dir={build,third_party} BUILD_TARGET ./.github/
./.github/workflows/openwrt.yml:52:        BUILD_TARGET: "openwrt-check"
./.github/workflows/build.yml:50:      run: BUILD_TARGET=pretty-check tests/scripts/bootstrap.sh
./.github/workflows/build.yml:62:      BUILD_TARGET: check
./.github/workflows/build.yml:85:      BUILD_TARGET: check
./.github/workflows/build.yml:104:      BUILD_TARGET: script-check
./.github/workflows/build.yml:120:      BUILD_TARGET: scan-build
./.github/workflows/build.yml:135:      BUILD_TARGET: package
./.github/workflows/build.yml:152:      BUILD_TARGET: check
./.github/workflows/meshcop.yml:57:        BUILD_TARGET: "meshcop"
./.github/workflows/docker.yml:56:        BUILD_TARGET: "docker-check"
./.github/workflows/raspbian.yml:49:      BUILD_TARGET: raspbian-gcc
./.github/workflows/documentation.yml:44:      BUILD_TARGET: check
./.github/workflows/ncp_mode.yml:52:        BUILD_TARGET: ncp_mode

@Irving-cl Irving-cl added P4 cleanup github_actions Pull requests that update GitHub Actions code labels Feb 1, 2025
@Irving-cl Irving-cl requested a review from jwhui February 1, 2025 03:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.58%. Comparing base (2b41187) to head (580b98c).
Report is 935 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2691       +/-   ##
===========================================
- Coverage   55.77%   43.58%   -12.20%     
===========================================
  Files          87      108       +21     
  Lines        6890    13359     +6469     
  Branches        0      963      +963     
===========================================
+ Hits         3843     5822     +1979     
- Misses       3047     7231     +4184     
- Partials        0      306      +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui merged commit 0a9a469 into openthread:main Feb 5, 2025
@Irving-cl Irving-cl deleted the clean_up_bootstrap branch February 6, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup github_actions Pull requests that update GitHub Actions code P4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants