Fix csl uncertainty reporting max value #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abtink
reviewed
Apr 17, 2024
| @@ -1416,7 +1416,7 @@ uint8_t otPlatRadioGetCslAccuracy(otInstance *aInstance) | |||
| return otPlatTimeGetXtalAccuracy() / 2; | |||
| } | |||
|
|
|||
| uint8_t otPlatRadioGetCslClockUncertainty(otInstance *aInstance) | |||
| uint8_t otPlatRadioGetCslUncertainty(otInstance *aInstance) | |||
There was a problem hiding this comment.
Should we remove the weak implemenation in OT?
We can expect any radio platform supporting CSL should provide this?
|
To add onto this. Testing the code using the correct value has caused increased synchronization loss in my networks. Especially using the nrf52840 dev kits. In my test setup i had to increase the uncertainty to 40 (from its default of 20). I havent tested any value below 40 aside from the default yet. Is this something that needs to be addressed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function to query the csl uncertainty has an incorrect name in the nrf code
otPlatRadioGetCslClockUncertaintyas opposed tootPlatRadioGetCslUncertainty. See https://github.com/openthread/openthread/blob/main/include/openthread/platform/radio.h#L1212 .Since openthread has a default weak implementation of the function this doesn't cause any linker errors but instead silently uses 255 which effectively increases the CSL window by a constant 10ms.