Fix item duplication on containers with more items than cap

[Kamenuvol]

Description

If there is a container without pagination and more items than its capacity, the last item is duplicated when removing items. This commit fixes it and also make Container::addItem more symmetric with Container::removeItem.

Behavior

Actual

Add more items to a container than its capacity. Different items to see better the difference.
Remove any of them until when you would had an empty space, but there will be no empty space, just a duplicated last item.

Expected

Only one last item (skull staff)

Type of change

• Bug fix (non-breaking change which fixes an issue)

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[kokekanon]

I can't reproduce the error that this PR is trying to fix. Also, I see that you're using release 3.5.

i test in main repo
canary 11.00

player knight cap 1065, level 69
bag client id : 2854 "backpack" 20 slot

Can you be more clear, the steps to reproduce the error?

[Kamenuvol]

I can't reproduce the error that this PR is trying to fix. Also, I see that you're using release 3.5.

i test in main repo canary 11.00

player knight cap 1065, level 69 bag client id : 2854 "backpack" 20 slot

Can you be more clear, the steps to reproduce the error?

A backpack, for example, has 20 spaces, fill it with 21 items forcing using flag, then remove the items.