adding extra Archive Tests, adding contract annotations for ArchiveLayout #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#148 Pointed out to me a couple of missing test paths for the SDK here. It doesn't appear that the code path they suggested is failing, still waiting on clarity - but it's still worth adding the cases. |
…lization of the stylesheet for non-custom layouts
…pentok-.NET-SDK into add_extra_archive_test
slorello89
changed the title
|
After further discussion with the originator of #148 it's clear what's going on here - when the stylesheet is being set to an empty string it's erroneously being serialized with the rest of the |
dragonmantank
requested changes
Aug 31, 2020
dragonmantank
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some missing test cases for the ArchiveLayout StartArchive paths.