Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support of spring boot 3.0 (#146) #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onyn
Copy link

@onyn onyn commented Jan 13, 2023

Spring boot 2.7 introduces new way for registering autoconfiguration classes. And then spring.factories file was deprecated.
As of boot 3.0 support of spring.factories files was dropped.

See also:
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#auto-configuration-files

Spring boot 2.7 introduces new way for registering autoconfiguration classes.
And then spring.factories file was deprecated.
As of boot 3.0 support of spring.factories files was dropped.

Closes: opentracing-contrib#146

See also:
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#auto-configuration-files
@dhladik
Copy link

dhladik commented Jan 20, 2023

This should get merged and released ASAP. A really simple fix for failing to start the Spring Boot app. Thanks @onyn

@gdisanto
Copy link

Hi all,
Will this fix be merged eventually? At the moment, we are using a workaround to make the library working with Spring boot 3.

@onyn
Copy link
Author

onyn commented May 15, 2023

Starting Jan 31, 2022 OpenTracing project was archived by CNCF. Also official OpenTracing website suggests migration to OpenTelemetry. I think OpenTracing project have no future and any development was abandoned in favor of OpenTelemetry.

Moreover, spring promotes its own solution for tracing - Micrometer Tracing, starting from boot 3.0. This is facade over OpenTelementry tracer.

Just forget about OpenTracing and move to Micrometer.

@gdisanto
Copy link

gdisanto commented Jun 1, 2023

Thanks @onyn, I think you are right... it looks like this project is not supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants