Release script for downstream OTP forks #6345
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
force-pushed
the
release_scripts
branch
from
83f13fb to
0e4a19f
Compare
|
I will add a check on the environment to the |
|
There are formatting issues. |
leonardehrenfried
changed the title
t2gran
force-pushed
the
release_scripts
branch
from
b58fcc8 to
77a9ed5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6345 +/- ##
=============================================
- Coverage 69.85% 69.78% -0.07%
- Complexity 17922 17926 +4
=============================================
Files 2035 2036 +1
Lines 76495 76585 +90
Branches 7824 7833 +9
=============================================
+ Hits 53435 53445 +10
- Misses 20324 20400 +76
- Partials 2736 2740 +4 ☔ View full report in Codecov by Sentry. |
|
I have improved the error handling in the scripts and simplified a bit. Ready for review. |
optionsome
reviewed
Jan 3, 2025
| Also note that the CI configuration is changed (c2) and this change needs to be included in the | ||
| new release (v3). | ||
|
|
||
| > **Note!** OTP ignore config it does not understand it. This allows us to roll out config for new |
There was a problem hiding this comment.
Suggested change
| > **Note!** OTP ignore config it does not understand it. This allows us to roll out config for new | |
| > **Note!** OTP ignores config it does not understand it. This allows us to roll out config for new |
|
|
||
| You should create a branch in the local git repository where you keep your deployment-specific | ||
| config. The `ext_config` branch should have **one** commit with all changes needed. If you need to | ||
| change the config, you will have to amend the changes. This is because the release script chery-pick |
There was a problem hiding this comment.
Suggested change
| change the config, you will have to amend the changes. This is because the release script chery-pick | |
| change the config, you will have to amend the changes. This is because the release script cherry-pick |
| Run the `prepare_release` script. The script does the following: | ||
| - Reset main to the right latest commit on `dev-2.x` | ||
| - Rebase and merge in the `ext_config` extension branches into the local release branch. You will | ||
| be prompted for each step allowing you to perform/skip the steps you want. Also. the script keeps |
There was a problem hiding this comment.
Suggested change
| be prompted for each step allowing you to perform/skip the steps you want. Also. the script keeps | |
| be prompted for each step allowing you to perform/skip the steps you want. Also, the script keeps |
There was a problem hiding this comment.
Shouldn't this file have .sh file extension?
t2gran
added
Entur Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contain two scripts
prepare_releaseandreleaseto make a release in a DOWNSTREAM fork of OTP. These scripts are not intended for releasing the main OTP repository.See the (RELEASE_README)[script/RELEASE_README.md] for documentation of these scripts.
Issue
🟥 There is not issue for this. But, these scripts is requested from time to time. This PR provides a common place to maintain them.
Unit tests
🟥 There is a Java class in the utils module in this PR. It does not have tests, but it should be converted to a script. Not sure if we needs unit-tests on scripts.
Documentation
✅ The scripts are documented in the readme, se above.
Changelog
✅ This is relevant for advanced deplyments.
Bumping the serialization version id
🟥 Not relevant.