route viewer overlay: avoid MultiPolygon crash #798
Conversation
|
typescript is failing |
| @@ -127,9 +127,34 @@ const RouteViewerOverlay = (props: Props): JSX.Element => { | |||
| reduceBounds, | |||
| bounds || new LngLatBounds(coordsArray[0], coordsArray[0]) | |||
| ); | |||
| } else if (geoJson?.type === "GeometryCollection") { | |||
| const { geometries } = geoJson; | |||
There was a problem hiding this comment.
I don't think this is correct. Should it be stop.geometries.geometries? geoJson is coming from stop.geometries above
There was a problem hiding this comment.
Fixed it!
There was a problem hiding this comment.
I think we can do better than this! If this isn't always going to be a Polygon then why not update the type in the types package? This type is coming from the Stop type on line 502 of types.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
| @@ -127,9 +127,34 @@ const RouteViewerOverlay = (props: Props): JSX.Element => { | |||
| reduceBounds, | |||
| bounds || new LngLatBounds(coordsArray[0], coordsArray[0]) | |||
| ); | |||
| } else if (geoJson?.type === "GeometryCollection") { | |||
| const { geometries } = geoJson; | |||
There was a problem hiding this comment.
I think we can do better than this! If this isn't always going to be a Polygon then why not update the type in the types package? This type is coming from the Stop type on line 502 of types.
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
Typescript is really broken here I think. I can type line 131 as GeoJSON.Geometry but TS still thinks there's no |
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
Good catch thanks! |
Previously the multi polygon data structure broke the bounds checking. Since we don't support rendering that anyway, this PR catches this case and avoids a crash. The whole thing needs refactoring anyway. GeoJSON was built for functional programming and that's what should be done here.