Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTEST: Refactored protocol selection mock #10369

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

iyastreb
Copy link
Contributor

What?

This PR contains enhancements of the original protocol selection mock (#9989):

  • Ability to mock any number of devices with different capabilities
  • Match the exact config of protocol selection (e.g. rc_mlx5/mock_0:1 50% on path0 and 50% on path1)
  • Small improvements

Finally all those changes are needed to reproduce real protocol selection issues (like https://redmine.mellanox.com/issues/4177809, https://redmine.mellanox.com/issues/4134043)

test/gtest/ucp/test_ucp_proto_mock.cc Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Outdated Show resolved Hide resolved
brminich
brminich previously approved these changes Jan 7, 2025
rakhmets
rakhmets previously approved these changes Jan 8, 2025
test/gtest/common/test_helpers.h Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_proto_mock.cc Show resolved Hide resolved
@iyastreb iyastreb dismissed stale reviews from rakhmets and brminich via 07be704 January 13, 2025 09:05
@iyastreb iyastreb force-pushed the gtest/mock-proto-select2 branch from eb07ca3 to b52902d Compare January 13, 2025 17:05
@yosefe yosefe enabled auto-merge January 14, 2025 10:53
@yosefe yosefe merged commit 3a9f02a into openucx:master Jan 14, 2025
146 checks passed
@iyastreb iyastreb deleted the gtest/mock-proto-select2 branch January 15, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants