UCT/CUDA/CUDA_COPY: Enabled memory attributes query after switching CUDA GPU. #10388
+216
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
force-pushed
the
topic/gtest-switch-gpu
branch
from
d31bb61 to
1adcb5e
Compare
tvegas1
reviewed
Dec 18, 2024
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakhmets
force-pushed
the
topic/gtest-switch-gpu
branch
from
4adf57b to
6d38f73
Compare
rakhmets
changed the title
brminich
reviewed
Feb 12, 2025
brminich
previously approved these changes
Feb 12, 2025
rakhmets
changed the title
brminich
reviewed
Feb 13, 2025
brminich
previously approved these changes
Feb 13, 2025
tvegas1
previously approved these changes
Feb 13, 2025
iyastreb
previously approved these changes
Feb 14, 2025
iyastreb
previously approved these changes
Feb 14, 2025
brminich
previously approved these changes
Feb 14, 2025
tvegas1
previously approved these changes
Feb 14, 2025
yosefe
reviewed
Feb 24, 2025
Comment on lines
52
to
57
| uct_md_mem_attr_t mem_attr = {}; | ||
| mem_attr.field_mask = UCT_MD_MEM_ATTR_FIELD_MEM_TYPE; | ||
| EXPECT_EQ(uct_md_mem_query(m_md.get(), mem.address, size, &mem_attr), | ||
| UCS_OK); | ||
| EXPECT_EQ(mem_attr.mem_type, UCS_MEMORY_TYPE_CUDA); | ||
| EXPECT_EQ(uct_mem_free(&mem), UCS_OK); |
There was a problem hiding this comment.
shall we check different allocation/memory types like VMM, Managed, etc? Can do it using several test functions (cases)
I would allocate memory here using Cuda API directly and not using UCT to test these cases
There was a problem hiding this comment.
Added test cases for different memory types.
yosefe
reviewed
Feb 25, 2025
|
|
||
| void cuda_fabric_mem_buffer::destroy() | ||
| { | ||
| switch (m_state) { |
There was a problem hiding this comment.
maybe we don't need to save the state as member var: when cuXX api fails during the constructor, rollback the state (using goto) and skip the test after the rollback. then can probably remove init/destroy wrappers and catching of skip exception
brminich
previously approved these changes
Feb 26, 2025
yosefe
previously approved these changes
Feb 26, 2025
tvegas1
previously approved these changes
Feb 26, 2025
|
@tvegas1 addressed your comment. Deleted by mistake. |
brminich
approved these changes
Feb 27, 2025
rakhmets
force-pushed
the
topic/gtest-switch-gpu
branch
from
aa78963 to
39f917a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enabled memory attributes query by
cuda_cpymemory domain after switching CUDA GPU.Added test.
Without the changes in
cuda_cpymemory domain the test fails with the following error: