UCP/WIREUP: No invalidate with overriden RNDV pipeline error handling #10745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
approved these changes
Jun 27, 2025
yosefe
requested changes
Jun 29, 2025
| if ((ep_init_flags & UCP_EP_INIT_ERR_MODE_PEER_FAILURE) && | ||
| ucp_context_rndv_is_enabled(context)) { | ||
| ucp_context_rndv_is_enabled(context) && | ||
| !context->config.ext.rndv_errh_ppln_enable) { |
There was a problem hiding this comment.
this fix looks weird.. we don't need invalidation for pipelining protocols since today pipelining protocols do not use it. And we would still need invalidation for zero-copy rndv protocols (if enabled), regardless of config.ext.rndv_errh_ppln_enable
There was a problem hiding this comment.
this is to avoid creating another var which would allow creating rma_bw lanes even if there is no any transport supporting that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Do not mandate RMA invalidation on
rma_bwlanes if RNDV pipelining will anyways override error handling.Why?
As error handling is not implemented for RNDV pipelining, there is no need to restrict to transports supporting RMA invalidation.
How?
Check applicable configuration and test with
ucx_perftest -e.