-
Notifications
You must be signed in to change notification settings - Fork 488
UCP/PROTO: Protocol variants #10778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iyastreb
wants to merge
19
commits into
openucx:master
Choose a base branch
from
iyastreb:ucp-multi-proto-variants
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UCP/PROTO: Protocol variants #10778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ff9447
to
641e4c9
Compare
641e4c9
to
2d3196d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces protocol variants for multi-protocols.
The problem: with existing implementation is that for multi-protocols selection we always prefer high-bw combination of lanes (for instance
cuda_ipc
), which might not be the best choice on low message dimensions. Because high-bw protocols often have higher latency.This PR attempts to solve this problem by introducing protocol variants, so that for a single multi-protocol we may select multiple protocols: currently high-bw lanes selection and low-latency lanes selection.
Why?
Improve performance of multi-protocols on low message dimensions.
How?
UCX_PROTO_VARIANTS
option that enables this feature with default valuen
TODO in next PRs:
UCX_PROTO_VARIANTS=y
by defaultTesting results