Pass nodelay flag in ucp perftest #10894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofirfarjun7
changed the title
yosefe
reviewed
Sep 17, 2025
Comment on lines
71
to
73
| size_t m_size; | ||
| ucp_device_request_t m_requests[CAPACITY]; | ||
| uint8_t m_pending[UCX_BITSET_SIZE(CAPACITY)]; | ||
| uint8_t m_pending[UCX_BITSET_SIZE(CAPACITY)]; |
| status = ucp_device_put_single<level>(mem_list, mem_list_index, address, | ||
| remote_address, length, 0, &req); | ||
| remote_address, length, | ||
| UCP_DEVICE_FLAG_NODELAY, &req); |
There was a problem hiding this comment.
Hmm, it works fine on my side without this flag
There was a problem hiding this comment.
Can we keep only this change and exclude formatting changes?
There was a problem hiding this comment.
Did it worked for you with two nodes? With single node & cudaipc it will not go throw NIC so it will work without DB. (Maybe this is why CI passed?)
I can just add the flag and revert the rest. We need it to measure perf so I don't want to wait for PR with many changes that require review
There was a problem hiding this comment.
Right, I haven't tested with two nodes
Thanks for reducing the change
yosefe
previously approved these changes
Sep 18, 2025
iyastreb
approved these changes
Sep 18, 2025
brminich
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pass
UCP_DEVICE_FLAG_NODELAYflag when posting in UCP perftest.Why?
Test hangs without it.