Skip to content

Conversation

Laur1nMartins
Copy link

This change allows the basedir variable to contain spaces.

What?

Adds quotes to the basedir variable.

Why?

Without them the script fails when the path contains spaces.

@Laur1nMartins Laur1nMartins marked this pull request as draft September 19, 2025 07:35
@Laur1nMartins Laur1nMartins changed the title Update configure-devel to handle spaces in basedir BUILD/SCRIPTS: Update configure-devel to handle spaces in basedir Sep 19, 2025
@Laur1nMartins Laur1nMartins changed the title BUILD/SCRIPTS: Update configure-devel to handle spaces in basedir CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir Sep 19, 2025
@Laur1nMartins Laur1nMartins marked this pull request as ready for review September 19, 2025 07:53
yosefe
yosefe previously approved these changes Sep 20, 2025
@tvegas1
Copy link
Contributor

tvegas1 commented Sep 23, 2025

to unblock ci please add diff below and fix commit title with:
./contrib/squash_commit.sh -m "CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir" -r origin/master

diff --git a/AUTHORS b/AUTHORS
index c25b3bb6a..116dfe9a2 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -59,6 +59,7 @@ Keisuke Fukuda <[email protected]>
 Ken Raffenetti <[email protected]>
 Khaled Hamidouche <[email protected]>
 Konstantin Belousov <[email protected]>
+Laurin Martins <[email protected]>
 Leonid Genkin <[email protected]>
 Lior Paz <[email protected]>
 Luis E. Pena <[email protected]>

tvegas1
tvegas1 previously approved these changes Sep 23, 2025
@yosefe
Copy link
Contributor

yosefe commented Sep 25, 2025

Hi @Laur1nMartins , in order to merge the patch to upstream a signed CLA is required - https://github.com/openucx/ucx/wiki/Guidance-for-contributors. Any chance you already signed it previously?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants