Added new scale selection highlighting in piano roll + refactored music theory utils

[AntoineHazebrouck]

(first dev on any open source project, I'm new so I don't know the process and all)

Following this feature request : #2005

Behavior comparison

Default scale is C Ionian or C major (this did not change), users can still select the Key (aka tonic)

Users can now also select the mode out of the main ones, here we can for example have A minor (relative of C major) which was not possible before :

Before that, we could only have C major for the proper notes but the wrong degree intervals if we wanted A minor.

Also the notes highlighting (black and white keys) only followed a traditionnal piano, now the highlighting clearly follows the scale that you play in. The selected tonic is now highlighted in light blue whereas only the C note was before.

If users wish to keep the traditionnal piano highlighting, they can keep C major as the scale.

Implementation details

Uproject now has a new field : "mode" which is reflected by the dropdown menu shown above. Everything related to music theory AND required for this feature has been moved to this namespace : "OpenUtau.Core.Util.MusicTheory".

[maiko3tattun]

Scale degree display style isn't working

[BagelHero]

Nice first PR! Thank you for adding images, details, and the link back to the relevant issue, makes things much easier to check over. :)

[AntoineHazebrouck]

Thank you for checking out! So from now on, how does it work for the PR to be integrated, and why are the pipelines not running?

[BagelHero]

First-time contributors' checks need to be manually approved, if I remember correctly. Might just be a quirk, a few of our test systems need a bit of ironing out. From here our primary maintainer StAkira will review the code , approve the workflow tests, and merge if he has no revisions. I've tagged him in for review for you.

We can go a long while between stable version releases, but once merged your feature will be available in the next alpha build (which is nightly), and hopefully moved quickly into beta which more people tend to use. 😊