[WIP] MIDI Keyboard Support and Step Input - #2405
Draft
maiko3tattun wants to merge 2 commits into
Draft
maiko3tattun wants to merge 2 commits into
maiko3tattun wants to merge 2 commits into
Conversation
Contributor
|
For Stakira, the failing tests is not a fault of the PR. Please merge #2398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented:
Pressing a key on the MIDI keyboard produces a sound
Pressing a key inserts a note at the cursor position
Holding down a key extends the note
Pre-roll (separate PR)
To Do:
Select a MIDI device
Toggle step input
Set input sensitivity (how fast notes extend)
Shortcut keys to move the playhead (separate PR)