Skip to content

Conversation

@lukhnos
Copy link
Collaborator

@lukhnos lukhnos commented Dec 19, 2025

  • Streamlined, consolidated number input mode
  • Fixes the mismapped '9' key on numpad
  • Fixes non-functional Shift+[1-9] keys if Shift+Enter was disabled for associated phrases

Copilot AI review requested due to automatic review settings December 19, 2025 02:55
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the project version to 2.9.5. The version number has been updated in CMakeLists.txt and src/CMakeLists.txt, and a new release entry has been added to org.fcitx.Fcitx5.Addon.McBopomofo.metainfo.xml.in. The changes are consistent and correctly implement the version bump. The modifications appear correct and I have no further feedback.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the project version from 2.9.4 to 2.9.5, incorporating fixes for number input mode functionality, numpad key mapping, and Shift+number key combinations.

  • Updates version number consistently across all CMakeLists.txt files
  • Adds release metadata entry with today's date
  • Follows established version bump patterns

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/CMakeLists.txt Updates project version from 2.9.4 to 2.9.5
CMakeLists.txt Updates project version from 2.9.4 to 2.9.5
org.fcitx.Fcitx5.Addon.McBopomofo.metainfo.xml.in Adds release entry for version 2.9.5 with date 2025-12-19

@zonble zonble merged commit 2327e62 into openvanilla:master Dec 19, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants