Skip to content

Conversation

@lukhnos
Copy link
Collaborator

@lukhnos lukhnos commented Dec 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 19, 2025 17:06
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pkgver in the Arch Linux PKGBUILD. While the version bump is a standard maintenance task, I've identified an issue with the version string format. It deviates from the standard Arch Linux convention for VCS packages by omitting the 'g' prefix from the git hash. I've left a specific comment on the pkgver line explaining the issue, its root cause in the pkgver() function, and how to fix it to ensure future versions adhere to the standard format.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Arch Linux PKGBUILD file to reflect version 2.9.5 of the fcitx5-mcbopomofo package. The version bump aligns with updates already made in the main CMakeLists.txt and metainfo files.

  • Updates pkgver from 2.9.4.r0.0111c1f to 2.9.5.r0.2327e62

@xatier
Copy link
Contributor

xatier commented Dec 19, 2025

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants