[codex] Left-align equivalent indels#173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR teaches
ReadCollectorto left-align equivalent indels within a read alignment so that homopolymer insertions/deletions are counted against the queried canonical variant instead of being treated as reference support.What changed
pysamaligned pairs when a specific variant is being queriedAlleleRead.from_locus_read(...)so it trusts the collector's logical interval for canonicalized insertionsisovarto1.4.23Why
Issue #79 is a correctness bug: DNA variants are generally left-aligned, but RNA aligners may place an equivalent indel later within a repeat. Isovar previously compared only the literal allele at the queried locus, so those equivalent alignments were counted as ref/other instead of alt.
Impact
Validation
./lint.sh./test.shCloses #79