Skip to content

[codex] Prune impossible assembly merge pairs#174

Merged
iskandr merged 1 commit intomasterfrom
improve-assembly-scaling
Apr 23, 2026
Merged

[codex] Prune impossible assembly merge pairs#174
iskandr merged 1 commit intomasterfrom
improve-assembly-scaling

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Apr 23, 2026

Summary

  • add an exact k-mer candidate index before greedy assembly pair scoring so obviously impossible sequence pairs are never compared
  • keep the existing deterministic merge semantics by leaving VariantSequence.combine as the authoritative merge check
  • add a regression test showing disjoint sequences now skip pairwise combine calls entirely

Validation

  • ./lint.sh
  • ./test.sh

Closes #147

@iskandr iskandr marked this pull request as ready for review April 23, 2026 17:31
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 93.391% (-0.009%) from 93.4% — improve-assembly-scaling into master

@iskandr iskandr merged commit 0acd618 into master Apr 23, 2026
6 checks passed
@iskandr iskandr deleted the improve-assembly-scaling branch April 23, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assembly algorithm: correctness edge cases, O(n³) scaling, and improvement proposal

2 participants