Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchFX] Documetation update #2917

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Aug 26, 2024

Changes

  • Main README.md, Usage.md and post training quantization docs are updated with info about the TorchFX

Reason for changes

  • To reflect new experimental features of TorchFX in the docs

Related tickets

#2766

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 26, 2024
@daniil-lyakhov daniil-lyakhov force-pushed the dl/fx/docs branch 6 times, most recently from 339d95f to ba2afd4 Compare October 22, 2024 11:08
@daniil-lyakhov daniil-lyakhov changed the title WIP [TorchFX] Documetation update [TorchFX] Documetation update Oct 22, 2024
@daniil-lyakhov daniil-lyakhov marked this pull request as ready for review October 22, 2024 12:06
@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner October 22, 2024 12:06
README.md Outdated
# Using capture_pre_autograd_graph to export torch.fx.GraphModule
# the same way it done for PyTorch 2 Export Post Training Quantization:
# https://pytorch.org/tutorials/prototype/pt2e_quant_ptq.html
fx_model = capture_pre_autograd_graph(model.eval(), args=torch.ones(input_shape))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torch 2.5.0 introduced export_for_training method which is used for quantization pipeline https://pytorch.org/executorch/stable/tutorials/export-to-executorch-tutorial.html I'm waiting that NNCF will support torch 2.5.0 in the upcoming release. I would suggest to merge this PR after clarification the status of the task of supporting torch 2.5.0 in NNCF.
@anzr299, @MaximProshin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants