-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF FE][MOC] Fuse Keras LSTM to LSTMSequence and Optimize TF While with TensorList ops #25170
Merged
rkazants
merged 16 commits into
openvinotoolkit:master
from
rkazants:rkazants/lstm_keras_fusion
Jun 27, 2024
Merged
[TF FE][MOC] Fuse Keras LSTM to LSTMSequence and Optimize TF While with TensorList ops #25170
rkazants
merged 16 commits into
openvinotoolkit:master
from
rkazants:rkazants/lstm_keras_fusion
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th TensorList ops Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
…ormation Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
itikhono
reviewed
Jun 24, 2024
src/common/transformations/src/transformations/op_conversions/convert_ti_to_sequences.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/op_conversions/convert_ti_to_sequences.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/include/transformations/op_conversions/convert_ti_to_sequences.hpp
Show resolved
Hide resolved
src/frontends/tensorflow_common/src/helper_transforms/tensor_list_ops_resolver.cpp
Outdated
Show resolved
Hide resolved
src/frontends/tensorflow_common/src/helper_transforms/tensor_list_ops_resolver.cpp
Outdated
Show resolved
Hide resolved
evkotov
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have performance measurements? Did this transformation improve?
src/common/transformations/src/transformations/op_conversions/convert_ti_to_sequences.cpp
Show resolved
Hide resolved
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Yes, 2x for customer model |
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
Signed-off-by: Kazantsev, Roman <[email protected]>
popovaan
reviewed
Jun 27, 2024
src/frontends/tensorflow_common/src/helper_transforms/tensor_list_ops_resolver.cpp
Show resolved
Hide resolved
evkotov
approved these changes
Jun 27, 2024
itikhono
approved these changes
Jun 27, 2024
src/frontends/tensorflow_common/src/helper_transforms/tensor_list_ops_resolver.cpp
Show resolved
Hide resolved
src/common/transformations/src/transformations/op_conversions/convert_ti_to_sequences.cpp
Show resolved
Hide resolved
andrei-kochin
approved these changes
Jun 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
**Details:** Fix leftovers for Keras LSTM fusion transformation #25170 **Tickets:** TBD Signed-off-by: Kazantsev, Roman <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
**Details:** Fix leftovers for Keras LSTM fusion transformation #25170 **Tickets:** TBD Signed-off-by: Kazantsev, Roman <[email protected]>
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…th TensorList ops (openvinotoolkit#25170) **Details:** Fuse Keras LSTM to LSTMSequence and Optimize TF While with TensorList ops. Loop operations with TensorListSetItem transformed to ConcatOutput outputs. Loop operations with TensorListGetItem transformed to SlicedInput inputs. It helps to fuse six loops with LSTMCell to six LSTM sequence model. It reduces customer model size by twice and increase throughput by 1.97x. **Tickets:** TBD --------- Signed-off-by: Kazantsev, Roman <[email protected]>
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…vinotoolkit#25268) **Details:** Fix leftovers for Keras LSTM fusion transformation openvinotoolkit#25170 **Tickets:** TBD Signed-off-by: Kazantsev, Roman <[email protected]>
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…th TensorList ops (openvinotoolkit#25170) **Details:** Fuse Keras LSTM to LSTMSequence and Optimize TF While with TensorList ops. Loop operations with TensorListSetItem transformed to ConcatOutput outputs. Loop operations with TensorListGetItem transformed to SlicedInput inputs. It helps to fuse six loops with LSTMCell to six LSTM sequence model. It reduces customer model size by twice and increase throughput by 1.97x. **Tickets:** TBD --------- Signed-off-by: Kazantsev, Roman <[email protected]>
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…vinotoolkit#25268) **Details:** Fix leftovers for Keras LSTM fusion transformation openvinotoolkit#25170 **Tickets:** TBD Signed-off-by: Kazantsev, Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: TF FE
OpenVINO TensorFlow FrontEnd
category: TFL FE
OpenVINO TensorFlow Lite FrontEnd
category: transformations
OpenVINO Runtime library - Transformations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: Fuse Keras LSTM to LSTMSequence and Optimize TF While with TensorList ops.
Loop operations with TensorListSetItem transformed to ConcatOutput outputs.
Loop operations with TensorListGetItem transformed to SlicedInput inputs.
It helps to fuse six loops with LSTMCell to six LSTM sequence model. It reduces customer model size by twice and increase throughput by 1.97x.
Tickets: TBD