Use array for tracking memory usage instead of map #25269
+31
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::map` has very slow access are requires lock on every access. We can use `std::array` instead to hold compile time known number of buckets. This method should have less latency and memory overhead, as well as possibly no lock on access.
No need to lock mutex to update atomic values
|
build_jenkins |
|
Hi @ialbrecht, |
| std::map<allocation_type, std::atomic<uint64_t>> _memory_usage_map; | ||
| std::map<allocation_type, std::atomic<uint64_t>> _peak_memory_usage_map; | ||
| std::array<std::atomic<uint64_t>, static_cast<size_t>(allocation_type::max_value)> _memory_usage_data; | ||
| std::array<std::atomic<uint64_t>, static_cast<size_t>(allocation_type::max_value)> _peak_memory_usage_data; |
There was a problem hiding this comment.
Looks like array content has undefined values due to lack of explicit initialization
| _memory_usage_data[idx] += bytes; | ||
| auto new_val = _memory_usage_data[idx].fetch_add(bytes); | ||
| // Make sure actual maximum value is stored | ||
| while (new_val > _peak_memory_usage_data[idx]) { |
There was a problem hiding this comment.
Any reason to have while instead of if here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
std::maphas very slow access are requires lock on every access. We can usestd::arrayinstead to hold compile time known number of buckets.arraycontainer has lower access latency and memory overhead.