Skip to content

Resolve VID's to local store when requesting relationship #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chengr4 wants to merge 2 commits into from
Closed

Resolve VID's to local store when requesting relationship #189

chengr4 wants to merge 2 commits into from
+91 −13

Conversation

@chengr4
Copy link
Contributor

@chengr4 chengr4 commented Jul 4, 2025

Fix part of #130

chengr4 added 2 commits July 4, 2025 13:47
@chengr4
test: Add test for unverified receiver relationship request
5c11317 
    test test_request_command_unverified_receiver_default ... FAILED

    Unexpected stderr, failed var.contains(sent relationship request)
    ├── var: ERROR tsp: error sending message from alice to did:web:did.teaspoon.world:endpoint:test_wallet_DPMsqRO5: Error: unresolved vid did:web:did.teaspoon.world:endpoint:test_wallet_DPMsqRO5
    └── var as str: ERROR tsp: error sending message from alice to did:web:did.teaspoon.world:endpoint:test_wallet_DPMsqRO5: Error: unresolved vid did:web:did.teaspoon.world:endpoint:test_wallet_DPMsqRO5

Signed-off-by: R4 Cheng <[email protected]>
@chengr4
feat: Add confirmation prompt for unverified receiver DID verificatio…
c99cca2 
…n (request command)

    - refactor the logic into function `ensure_vid_verified`

    test test_send_command_unverified_receiver_ask_flag ... ok
    test test_request_command_unverified_receiver_default ... ok
    test test_send_command_unverified_receiver_default ... ok

Signed-off-by: R4 Cheng <[email protected]>
@chengr4
Copy link
Contributor Author

chengr4 commented Jul 4, 2025

I’m working on setting up tests for the request/receive relationship in cli_tests. From what I understand, the sender sends a request and listens for a response from the receiver. However, I’m unclear on how the receiver obtains the thread_id. Could someone clarify this part for me?

@michielp1807
Copy link
Contributor

michielp1807 commented Jul 7, 2025

Hi! The thread id is contained within the relationship request, and the CLI prints it after the VID such that it can be captured by scripts. Take a look at the cli-demo-routed-cli-only.sh example script, which captures the thread id to accept relationship requests.

We've considered simplifying this such that the accept command has an option to first listen for an incoming relationship request, similar to the --wait flag of the request command. This way, you wouldn't have to explicitly deal with the thread ids, as this would be dealt with internally. Perhaps this is also something you could look into if you want to make this setup easier.

@chengr4 chengr4 mentioned this pull request Sep 26, 2025
Closed
@michielp1807
Copy link
Contributor

michielp1807 commented Sep 26, 2025

I've merged part of this PR as #229 with some additional clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chengr4 chengr4

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chengr4 @michielp1807