Skip to content

Conversation

@Jackylee2233
Copy link

✅ Solved Issues

The features involved in these issues are explicitly mentioned as developed, tested, and merged in the Phase 2 and Phase 3 reports you provided. (Please check reports inthe ADR folder )

  • Accept parallel relationships #236: Accept parallel relationships
    • Analysis: ADR-001 (Relationship State Machine), Section 2 "Concurrency Handling", specifically defines how to handle concurrent relationship requests (by comparing thread_id to decide who accepts whom). The Phase 2 Report confirms that "Solved conflict of simultaneous requests via thread_id comparison" has been implemented and released as a core feature.
  • 'tsp' test code not showing correct relationship table #238: 'tsp' test code not showing correct relationship table
    • Analysis: The Phase 2 Report states that a complete relationship state machine (Unrelated -> Unidirectional -> Bidirectional) was implemented, fixing the issue of undefined states, and the RelationshipStatus enum was updated. This directly resolves the root cause of the incorrect or confusing relationship state display in tests.
  • a new tsp sdk api for non-continuous transports #218: a new tsp sdk api for non-continuous transports
    • Analysis: ADR-003 (Offline Message Queue) and "Feature 3" of the Phase 2 Report implemented an offline message queue. The report mentions "Added queue_message and retrieve_pending_messages public methods" and their integration into SecureStore. This API is specifically designed to handle situations where the transport layer is unavailable (non-continuous).
  • parallel relationship forming doc #127: parallel relationship forming doc
    • Analysis: ADR-001 is this document, detailing the logic for parallel (concurrent) relationship formation and conflict resolution mechanisms. The Phase 2 report also confirms that this logic has been documented.

🚧 Partially Solved / Needs Verification

  • tsp sdk M3 (v0.81) manual testing #173: tsp sdk M3 (v0.81) manual testing
    • Analysis: The "Phase 5: Testing & Verification" section of the Phase 2 Report is extremely detailed, listing successful results for unit tests, CI flow verification, and smart-home-lock integration tests. While this largely covers the testing requirements, if this Issue refers to a specific "manual testing checklist," manual confirmation may be needed to ensure every item on the list has been checked.
  • nested relationship: manual section in the doc #126: nested relationship: manual section in the doc
    • Analysis: The Phase 3 Report mentions fixing the test_nested_automatic_setup test case, indicating that the code logic for nested relationships has been maintained. However, the report does not explicitly mention whether a user manual section (Manual Section) was written specifically for nested relationships.

pohlm01 and others added 12 commits December 11, 2025 22:23
Signed-off-by: Jackylee2233 <[email protected]>
v0.3.5 被 didwebvh-rs v0.1.9 直接依賴
v0.4.0 被 affinidi-data-integrity v0.2.4 依賴,而後者又被 didwebvh-rs v0.1.9 依賴

項目通過編譯及全部測試通過:

cargo test
   Compiling serde_json v1.0.145
   Compiling sqlx-core v0.8.6
   Compiling serde_with_macros v3.16.0
   Compiling quinn v0.11.9
   Compiling serde_with v3.16.0
   Compiling affinidi-secrets-resolver v0.4.0
   Compiling serde_json_canonicalizer v0.3.1
   Compiling reqwest v0.12.24
   Compiling affinidi-data-integrity v0.2.4
   Compiling sqlx-sqlite v0.8.6
   Compiling didwebvh-rs v0.1.10
   Compiling sqlx v0.8.6
   Compiling askar-storage v0.2.4
   Compiling aries-askar v0.4.6
   Compiling tsp_sdk v0.9.0-alpha2 (/home/qaoo8/Jobs/tsp/tsp_sdk)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 11.23s
     Running unittests src/lib.rs (/home/qaoo8/Jobs/tsp/target/debug/deps/tsp_sdk-acbb1369351abb06)

running 56 tests
test cesr::packet::test::test_message_to_parts ... ignored
test cesr::packet::test::envelope_without_confidential_data ... ok
test cesr::packet::test::envelope_without_nonconfidential_data ... ok
test cesr::packet::test::envelope_with_nonconfidential_data ... ok
test cesr::packet::test::envelope_failure ... ok
test cesr::packet::test::s_envelope_with_confidential_data_failure ... ok
test cesr::packet::test::test_nested_msg ... ok
test cesr::packet::test::test_decode_send_recv ... ok
test cesr::packet::test::test_3p_refer_rel ... ok
test cesr::packet::test::test_par_refer_rel ... ok
test cesr::packet::test::mut_envelope_with_nonconfidential_data ... ok
test cesr::packet::test::trailing_data ... ok
test cesr::packet::test::test_relation_forming ... ok
test cesr::packet::test::test_routed_msg ... ok
test cesr::test::demo_example ... ok
test cesr::test::decode_and_encode ... ok
test cesr::test::dont_gen_overlong_encoding ... ok
test cesr::test::encode_and_decode ... ok
test cesr::test::identifier_failure_3 - should panic ... ok
test cesr::test::identifier_failure_1 - should panic ... ok
test cesr::test::identifier_failure_variable - should panic ... ok
test cesr::test::identifier_failure_2 - should panic ... ok
test cesr::test::index_failure - should panic ... ok
test cesr::test::long_variable_data ... ok
test cesr::test::test_primitives ... ok
test store::test::test_add_verified_vid ... ok
test store::test::test_add_private_vid ... ok
test store::test::test_remove ... ok
test crypto::tests::seal_open_message ... ok
test store::test::test_make_relationship_request ... ok
test store::test::test_open_seal ... ok
test store::test::test_make_new_identity ... ok
test store::test::test_make_referral ... ok
test store::test::test_make_relationship_accept ... ok
test store::test::test_nested_manual ... ok
test secure_storage::test::test_vault ... ok
test vid::deserialize::test::deserialize ... ok
test store::test::test_make_relationship_cancel ... ok
test vid::did::web::tests::test_resolve_document ... ok
test vid::did::peer::test::encode_decode ... ok
test vid::did::web::tests::test_resolve_url ... ok
test vid::did::webvh::tests::test_create_webvh_success ... ok
test store::test::test_routed ... ok
test store::test::test_nested_automatic_setup ... ok
test transport::tls::tests::test_tls_transport ... ok
test transport::quic::tests::test_quic_transport ... ok
test test::test_large_messages ... ok
test test::test_anycast ... ok
test test::test_direct_mode ... ok
test test::test_nested_mode ... ok
test test::test_relation_forming ... ok
test test::test_routed_mode ... ok
test test::test_unverified_receiver_in_direct_mode ... ok
test transport::tcp::test::test_tcp_transport ... ok
test cesr::test::too_long_data_failure - should panic ... ok
test test::attack_failures ... ok

test result: ok. 55 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 1.52s

   Doc-tests tsp_sdk

running 4 tests
test tsp_sdk/src/lib.rs - (line 29) ... ok
test tsp_sdk/src/async_store.rs - async_store::AsyncSecureStore (line 22) ... ok
test tsp_sdk/src/async_store.rs - async_store::AsyncSecureStore::send_relationship_request (line 282) ... ok
test tsp_sdk/src/async_store.rs - async_store::AsyncSecureStore::send (line 213) ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.22s

all doctests ran in 2.49s; merged doctests compilation took 1.21s

Signed-off-by: Jackylee2233 <[email protected]>
Signed-off-by: Jackylee2233 <[email protected]>
…perty gate and updated and restructured the ADR documentation;

feat: 将嵌套关系功能置于 'resolve' 特性门控之下,并更新和重组了 ADR 文档。

Signed-off-by: Jackylee2233 <[email protected]>
… with documentation;

feat: 添加重试模块,队列模塊和关系机模块添加文档说明

Signed-off-by: Jackylee2233 <[email protected]>
Signed-off-by: Jackylee2233 <[email protected]>
@Jackylee2233 Jackylee2233 force-pushed the feature/relationship-state-machine branch from b7ffdb6 to 2ef6f7e Compare December 11, 2025 14:24
@Jackylee2233 Jackylee2233 deleted the feature/relationship-state-machine branch December 12, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants